It can be good if used properly. If you're doing tons of link-exchanges in a short period of time, then obviously Google will get suspicious, and it may penalise you.
Link exchange is generally more common just for traffic now, rather than search engine ranking as it was a few years a go.